search

genshinsim / gcsim.app

gcsim website
MIT License
2 stars 21 forks source link

Share URL behavior Adjustments #66

Open jordanlovato opened 2 years ago

jordanlovato commented 2 years ago

UI bug:

  1. Open a gz file in the viewer
  2. Go to the "Share" tab
  3. Create a Share link
  4. Go to the "Debug" tab
  5. Go back to the "Share" tab
  6. Observe that share url is no longer there and must be recreated

From Srl ah... yes. bad implementation cause the url is a local state that gets wiped when the component gets dropped

jordanlovato commented 2 years ago

Additionally, if a share url is being used, the UI still allows the generation of a superfluous share URL. In this case, I think the UI should supply the user with the current window URL, assuming it is a share URL.