search

genshinsim / gcsim

monte carlo combat simulation for genshin impact
MIT License
278 stars 91 forks source link

Prism.js (config editor highlighting) should be moved to this repository #1237

Closed k0l11 closed 5 months ago

k0l11 commented 1 year ago

Reasons are already outlined in #1162. https://github.com/srliao/prism

srliao commented 1 year ago

leaving this one for @unleashurgeek

k0l11 commented 1 year ago

From quick research, I don't think it's possible to use Prism.js / highlight.js with a custom language definition without forking the repository. Since we want to keep the forked repository up-to-date while keeping it inside of the gcsim repository, we can only include it via git subtree, but this would clutter our commit history with commits from the Prism.js / highlight.js folks. I think the best move going forward is to either implement the highlighting ourselves or choose a different package that allows for defining custom languages for highlighting without having to fork it.

unleashurgeek commented 1 year ago

Short term, best is to just fork the repository since we do not currently keep it up to date anyway.

Long term, I agree we need to find a different highlighting package that is better designed for custom languages

k0l11 commented 5 months ago

fixed in #2060 by removing the prismjs fork dependency entirely