rewrite code editor for web

genshinsim / gcsim

monte carlo combat simulation for genshin impact

MIT License

271 stars 89 forks source link

rewrite code editor for web #1518

Open k0l11 opened 1 year ago

k0l11 commented 1 year ago

In order to have a clean solution for:

syntax highlighting
code formatting
autocompletion
error detection
...

we should look into:

defining gcsl as a grammar using ANTLR to generate a parser in TS/Golang
this parser can then be used in combination with something like Monaco to implement the code editor
example tutorial: https://betterprogramming.pub/create-a-custom-web-editor-using-typescript-react-antlr-and-monaco-editor-bcfc7554e446

unleashurgeek commented 1 year ago

Note: monaco does not support mobile so may want simplified viewer by default/for mobile?

k0l11 commented 1 year ago

Maybe Codemirror 6 is better then? relevant: https://blog.replit.com/code-editors

srliao commented 1 year ago

Maybe Codemirror 6 is better then? relevant: https://blog.replit.com/code-editors

Notes I made a while back: https://github.com/genshinsim/gcsim/discussions/768

IIRC it doesn't even need to be defined in grammar. You have to provide something to parse the language (which we already had). I was going to look at it at some point....

k0l11 commented 3 months ago

related: #2060