genshinsim / gcsim

monte carlo combat simulation for genshin impact
MIT License
282 stars 91 forks source link

C1 Childe incorrect cooldown calculation #270

Closed soloxcx closed 2 years ago

soloxcx commented 2 years ago

childetest.gz

In here, C1 Childe is in melee stance for 10.48 seconds. His cooldown is then supposed to be (10.48 * .8) + 6 or 14.384s. However the sim is doing (10.48 + 6) * .8 or 13.184s.

I confirmed this is the Childe Main's discord. They use a melee duration calculator. Note the cells D23, J23, etc. show that the first formula is used.

Tsym-or-Tysm commented 2 years ago

Childe melee cooldown is actually stepwise - do we know whether this should this only be a special exception for the 2 parts of the function that have an additive component?

See: https://genshin-impact.fandom.com/wiki/Foul_Legacy:_Raging_Tide

soloxcx commented 2 years ago

Sorry about this one, think I was misinformed.

I have C1 Childe and gave it a test myself https://youtu.be/7upaxLUZ70M. Stayed in melee for almost exactly 11 seconds and got a 13.6 cooldown, which follows the second formula of (11 + 6) * .8.

Of course, this means that resource from Childe Mains is incorrect (which it apparently already is by not accounting for the stepwise time) and it's possible I'm missing something, so going to get confirmation

Tsym-or-Tysm commented 2 years ago

NP - Just realized that the Tartaglia guide also has a chart of CD, which looks to me like it's a straight 20% reduction.

Of course immediately afterwards they link to the Melee Duration Calculator sheet that apparently contradicts it, so something definitely smells kinda fishy haha.

https://keqingmains.com/tartaglia/#E_Foul_Legacy_Raging_Tide_Elemental_Skill

Let me know whenever you get confirmation!

soloxcx commented 2 years ago

Okay yeah it's straight up 20% reduction as already implemented. That calculator is just wack

Tsym-or-Tysm commented 2 years ago

Sounds good - closing then.