search

genshinsim / gcsim

monte carlo combat simulation for genshin impact
MIT License
288 stars 94 forks source link

Hydro swirl does not damage all three targets #901

Open skippi opened 2 years ago

skippi commented 2 years ago

This sim should have all three targets take at least one instance of hydro swirl damage, but only two of them do. We think this is caused by the 0 damage AoE instances incrementing the damage counter.

https://gcsim.app/v3/viewer/share/6020f2ee-d7ad-4d75-a449-19f5509f8b4f

soloxcx commented 2 years ago

per https://discord.com/channels/845087716541595668/884485336657444894/1017254162121101383

the swirl damage order in this case is perhaps supposed to be ST > ST > ST > AoE > AoE > AoE which would resolve this specific issue without having to verify if 0 damage instances increment the damage counter

skippi commented 1 year ago

Still an ongoing issue. Now trying to figure out swirl priority (for 3T, is it 3xST > 3xAoE, or 3x(ST > AoE)), documenting these images once we get to the issue: https://cdn.discordapp.com/attachments/845087716541595671/1060356392717914142/image.png https://cdn.discordapp.com/attachments/845087716541595671/1060357651705372672/image.png https://cdn.discordapp.com/attachments/845087716541595671/1060357982594023534/Genshin_Impact_2023.01.05_-_11.40.28.05.mp4 https://cdn.discordapp.com/attachments/845087716541595671/1060358004555391096/swirl_aggggggg.mp4

XochitlWolf commented 1 month ago

this sim when upgraded now damages all three targets with each hydro swirl https://gcsim.app/sh/6020f2ee-d7ad-4d75-a449-19f5509f8b4f