genssi-developer / GenSSI

GenSSI 2.0 - Generating Series for testing Structural Identifiability
14 stars 3 forks source link

Issue in genssiOrderTableau #24

Open kartikramachandrula opened 5 months ago

kartikramachandrula commented 5 months ago

While running the examples I got an error,

"Error: File: genssiOrderTableau.m Line: 644 Column: 1 Illegal use of reserved keyword "end"."

removing the end statement there lets the code run.

Wondering if this is the appropriate fix.

Thanks.

genssi-developer commented 5 months ago

I just looked at the code but I need some more time. When I open the module in MATLAB, I get a warning on line 644 that says "Parse error at END. Usage might be invalid MATLAB code." MATLAB is showing the "end" statement in line 643 as matching the function definition in line 414. However, when I open the module in Microsoft Visual Studio Code, it shows me the "end" in line 644 as matching the function in line 414. Something is very odd here.

genssi-developer commented 5 months ago

Hello Kartik, I found the problem. You can see that lines 620 to 622 have been commented out (as part of issue #22). This should also include line 623 (the end statement). In other words, you need to remove line 623, not line 644. I will try to make this change directly in the master branch. In case I don't get it right, you might need to fix this in your version. In any case, please continue your testing and let me know how it works out.