gentakojima / emojione-picker-ubuntu

Emoji picker for Ubuntu based on icons by Emojione
239 stars 14 forks source link

Global hotkey support #15

Closed HarmtH closed 7 years ago

HarmtH commented 8 years ago

Creates a socket the first time emojione-picker is started. When you try to start again, the search window is showed instead.

Bind any hotkey you want via unity settings, gnome hotkey settings, etc. to emojione-picker, to show the search window on hotkey press.

HarmtH commented 8 years ago

The diff looks huge due to the re-indenting, but the only changes are at the top and the bottom.

dKab commented 8 years ago

That would be very cool addition!

gentakojima commented 7 years ago

Thanks for the feature! However, I don't feel comfortable with the reindenting. Do you mind if I implement this by myself copying the code from here (giving proper credit)? Or maybe you can create a reindenting-less pull request?

HarmtH commented 7 years ago

No problem, go ahead and use this code just as an example :-)

On 9 Oct 2016 11:17, "Jorge Suárez de Lis" notifications@github.com wrote:

Thanks for the feature! However, I don't feel comfortable with the reindenting. Do you mind if I implement this by myself copying the code from here (giving proper credit)? Or maybe you can create a reindenting-less pull request?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/gentakojima/emojione-picker-ubuntu/pull/15#issuecomment-252474876, or mute the thread https://github.com/notifications/unsubscribe-auth/ACTm4izQMaEBMZ54PpxgCdD7kmL_4Pb2ks5qyLEugaJpZM4JD3QB .

gentakojima commented 7 years ago

Sorry, I fully understood what you did now and reindenting was ok to do. Thanks for the feature!