gentics / mesh-incubator

Project which is home for planned enhancements for Gentics Mesh
3 stars 0 forks source link

Plugin System: Fix Classloader Issues #125

Closed Jotschi closed 5 years ago

Jotschi commented 6 years ago

A deployed plugin can load classes from the system classloader. This can be very problematic if the plugin ships a library which is already part of the system classloader.

The DeploymentManager of Vert.x takes care of creating the classloader.

We have a test which actually tests that loading of parent deps works: https://github.com/gentics/vertx-filesystem-service-factory/blob/32dd3c8247934b944d4944b6693b3ae99a8baef8/src/test/java/io/vertx/filesystem/FilesystemVerticleFactoryTest.java#L146

Questions

Jotschi commented 5 years ago

Fixed with 0.37.0