gentics / mesh-incubator

Project which is home for planned enhancements for Gentics Mesh
3 stars 0 forks source link

Prometheus Metric Output #181

Closed Jotschi closed 4 years ago

Jotschi commented 5 years ago

Problem with histogram_quantile from metrics.

image

The result of histogram_quantile is not working because the output uses the quantile tag.

histogram_quantile(0.5, irate(vertx_http_servers_0_0_0_0:8080_requests[1m]))

It would work if the le tag would be used.

histogram_quantile()
histogram_quantile(φ float, b instant-vector) calculates the φ-quantile (0 ≤ φ ≤ 1) from the buckets b of a histogram. (See histograms and summaries for a detailed explanation of φ-quantiles and the usage of the histogram metric type in general.) The samples in b are the counts of observations in each bucket. Each sample must have a label le where the label value denotes the inclusive upper bound of the bucket. (Samples without such a label are silently ignored.) The histogram metric type automatically provides time series with the _bucket suffix and the appropriate labels.
https://prometheus.io/docs/prometheus/latest/querying/functions/

image3

'le' tag is not there (its quantile tag)

image2

Maybe related: https://tech.willhaben.at/monitoring-metrics-using-prometheus-a6d498dfcfba?gi=57e954489f3e

Suggestion:

Jotschi commented 4 years ago

We switched to micrometer in 1.1.0