search

gentilkiwi / mimikatz

A little tool to play with Windows security
http://blog.gentilkiwi.com/mimikatz
19.51k stars 3.75k forks source link

Questions about mimikatz's architecture #223

Open plowsec opened 5 years ago

plowsec commented 5 years ago

Hey,

I'm trying to adapt your code base so that we can use a better compiler than Visual Studio, and also cross-compile it from other platforms than Windows.

If you're interested, the temporary result lies here: https://github.com/rapid7/mimikatz/pull/2/files

One thing that's consistently given me a headache is the way you name/duplicate some files, folders and functions.

For instance, you have two "modules" folders with several files that are named the same way. There are _mdpapi.c files at three locations:

mimikatz/modules/kull_m_dpapi.c
mimikatz/mimikatz/modules/kuhl_m_dpapi.c
mimikatz/mimikatz/modules/dpapi/kuhl_m_dpapi.c

Would it be possible to document somewhere your design choices since they are not that obvious to those not acquainted with your code base?

Thank you for your work thus far, mimikatz is really great!

gentilkiwi commented 5 years ago

I will take a look on how I can make life easier for cross compilation. On the two module directory, one is for kull_m_ (low level modules, not only related to mimikatz), other is for kuhl_m_ (high level modules, only made for mimikatz usage)