testing infrastructure & core.find_* tests

[neuromusic]

TODO

• [ ] clust.py
• [ ] core.py
• [ ] events.py
• [ ] spiketrains.py
• [ ] viz.py

[neuromusic]

@MarvinT @theilmbh should we go ahead and merge this or write more tests first?

[MarvinT]

total test coverage: 12% core.py test coverage: 60%

Should we push for a total test coverage of 50%?

[neuromusic]

let's prioritize merging this before we start merging the other PRs

[neuromusic]

hmm. OK @MarvinT what's the right way to do this now that we have another 30ish commits on master?

merge/rebase this branch against master then keep working on adding test cases?

[neuromusic]

also: what's the right approach for testing all of the file reading functions in core.py?

o.O

should CoreTest.setupClass() create actual kwik/kwx/probe files in the temp dir?

[MarvinT]

This is why I have a testing branch based on master, I'll pull changes and make a new pull request because I don't think we can switch targets of a pull request.

Second, I think a good policy to have is to pull these changes in and require that every pull request from here on out increase the coverage. This can usually be done pretty easily by covering the new code by more than our current coverage which is currently at 12%

[neuromusic]

OK, I'l let you handle cleaning up the PRs then.

Agreed re increasing test coverage. 12% is a low bar

[coveralls]

Changes Unknown when pulling 2fef2e250630fecd897ee117b717288dcc796a2c on testing-merge-justin into \ on justin**.

[coveralls]

Changes Unknown when pulling 07d7521f5c884a63d1a28f1174abd4d9faa6e73c on testing-merge-justin into \ on justin**.

[MarvinT]

Replaced by PR #19