added logic to calculate datetime of trial starts and whether correction trial

gentnerlab / ephys-analysis

Scripts and utilities for processing electrophysiology data

BSD 3-Clause "New" or "Revised" License

11 stars 8 forks source link

added logic to calculate datetime of trial starts and whether correction trial #17

Closed neuromusic closed 8 years ago

neuromusic commented 8 years ago

this pull request adds two features:

each trial gets a datetime that is calculated from the recording metadata (in the info json file) and the time_samples of the trial
each trial gets a 'correction' column which computes whether the trial was a correction trial (might need to think through the edge cases here better)

neuromusic commented 8 years ago

oh snap. new bar. 23% coverage

@MarvinT will you take a peek at my tests? any tips?

coveralls commented 8 years ago

Coverage increased (+10.8%) to 22.776% when pulling b7f3a6653821de702cd9801bab2d17f96964eb14 on trial_datetimes into 7cfa66c973e403a963c532a5cef823afa133b598 on master.

MarvinT commented 8 years ago

Very nice! I like them.

Question about calc_rec_datetime: I'm not sure I understand the start_time parameter. Maybe we should have a default parameter of 0. It might also be nice to mention in the documentation that start_time is in seconds.

neuromusic commented 8 years ago

these parameters are keys in the 'rec' dictionaries that make_kwd drops into the json file.

that is, each "recording" corresponds to a continuously sampled epoch in Spike2, which starts some time after the beginning of the file. start_time is the time in seconds after the start of the file that the recording is sampled from

I'll flesh out the documentation on this

coveralls commented 8 years ago

Coverage increased (+10.8%) to 22.776% when pulling 93199eb4fb2363691fb247dc496457c12ec1787d on trial_datetimes into 7cfa66c973e403a963c532a5cef823afa133b598 on master.

neuromusic commented 8 years ago

updated docs. disagree re: default, as the start_time of the recording is rarely 0.0

will merge ASAP

coveralls commented 8 years ago

Coverage increased (+10.8%) to 22.776% when pulling 2e731cb8d018379ea20ebc5b47322464b68f8827 on trial_datetimes into 7cfa66c973e403a963c532a5cef823afa133b598 on master.