search

gentnerlab / ephys-analysis

Scripts and utilities for processing electrophysiology data
BSD 3-Clause "New" or "Revised" License
11 stars 8 forks source link

Q: what to do if you make changes to your branch after the inital submit of a pull request #3

Closed neuromusic closed 8 years ago

neuromusic commented 8 years ago

found @neurologic's question inline in the readme. moving it here.

if you make more changes to your branch after that.... create new pull request for same branch? does it automatically recognize new changes to that branch within the old pull request?

neuromusic commented 8 years ago

if you push the changes to origin (or on the gui, if you sync w/ github), then the pull request will recognize the changes

neuromusic commented 8 years ago

this is one of the beautiful parts of the pull request mechanism

  1. contributor creates a branch or fork
  2. contributor commits changes
  3. contributor submits pull request
  4. owner or team provides feedback on pull request
  5. contributor commits additional changes to address team's concerns
  6. team approves pull request

all of this is recorded in the pull request