search

gentnerlab / pyoperant

python package for operant conditioning
BSD 3-Clause "New" or "Revised" License
13 stars 15 forks source link

added resample code to utils #105

Closed timsainb closed 8 years ago

neuromusic commented 8 years ago

OK, since this is adapting code from a GPLv3 script, I'm going to need to familiarize myself with proper licensing before I can approve this PR. Pyoperant is currently GPL3, so I think it's OK as-is but I've been considering changing the licensing to BSD, which is the UC system's preferred open source license.

For now, just add it where ever you need to get it working in your scripts.

You also might want to consider setting it up as a separate python package.

Justin

On Tue, Jan 26, 2016 at 11:20 AM, timsainb notifications@github.com wrote:

You can view, comment on, or merge this pull request online at:

https://github.com/gentnerlab/pyoperant/pull/105 Commit Summary

  • added resample code to utils

File Changes

Patch Links:

— Reply to this email directly or view it on GitHub https://github.com/gentnerlab/pyoperant/pull/105.

gentnerlab-user commented 8 years ago

Some other notes on your code:

Justin

On Tue, Jan 26, 2016 at 11:29 AM, Justin Kiggins notifications@github.com wrote:

OK, since this is adapting code from a GPLv3 script, I'm going to need to familiarize myself with proper licensing before I can approve this PR. Pyoperant is currently GPL3, so I think it's OK as-is but I've been considering changing the licensing to BSD, which is the UC system's preferred open source license.

For now, just add it where ever you need to get it working in your scripts.

You also might want to consider setting it up as a separate python package.

Justin

On Tue, Jan 26, 2016 at 11:20 AM, timsainb notifications@github.com wrote:

You can view, comment on, or merge this pull request online at:

https://github.com/gentnerlab/pyoperant/pull/105 Commit Summary

  • added resample code to utils

File Changes

Patch Links:

— Reply to this email directly or view it on GitHub https://github.com/gentnerlab/pyoperant/pull/105.

— Reply to this email directly or view it on GitHub https://github.com/gentnerlab/pyoperant/pull/105#issuecomment-175190286.

neuromusic commented 8 years ago

I'm closing the pull request since we switched to BSD and the GPL code is incompatible.