gentoo-audio / audio-overlay

Gentoo overlay for music production
https://gentoo-audio.github.io/audio-overlay
GNU General Public License v2.0
41 stars 22 forks source link

x11-libs/ntk: pkgconfig file doesn't respect libdir #526

Closed NexAdn closed 1 year ago

NexAdn commented 1 year ago

I've just noticed that the libdir is hard-coded in NTK's .pc file: https://github.com/gentoo-audio/ntk/blob/720d8d33200ebd030df700c6c7a5a9cdf4581c03/ntk.pc.in#L3 This results in NTK setting the library search path to an invalid path on systems with lib64 as libdir (which means all amd64 systems with 17.1 profile are affected). This would normally require patching upstream, but given Jonathan not openly developing NTK any further I guess it's up to us to patch the .pc.in template to generate libdir from whatever is specified during build. After all, Gentoo is the only distro I am aware of with libdir=lib64, so this probably won't affect any other distro.

NexAdn commented 1 year ago

To add some context: I've actually noticed this on my machine with multilib cairo trying to compile a project built against NTK with meson. The linker failed to link the final executable, complaining about /usr/lib/libcairo.so being in an invalid format (which is correct, since it tried to link a 32 bit library in a 64 bit executable). So this does cause build problems on multilib systems.