search

gentoo / cargo-ebuild

[MIRROR] cargo extension that can generate ebuilds using the in-tree eclasses
https://gitweb.gentoo.org/proj/cargo-ebuild.git
Apache License 2.0
33 stars 10 forks source link

Cargo.toml: Use vendored libgit2 #21

Closed leonardohn closed 2 years ago

leonardohn commented 2 years ago

Libgit2 often goes through ABI changes, so most projects (including rustsec, used for the audit feature) are vendoring it by default. This commit adds the vendored-libgit2 feature on the rustsec crate, which closes #20.

gyakovlev commented 2 years ago

merged via gentoo infra git, thanks!

leonardohn commented 2 years ago

Does it make sense to add an useflag in case the user wants to use system's libgit2?

gyakovlev commented 2 years ago

nah, it always breaks abi, cargo-ebuild infrequently updated, chances for breakage are high. and I don't want to introduce a lower-bound version dep, because it will block libgit2 removals.

we had rust/cargo itself using system one, but it will be unable to update itself if libgit2 changes abi (with USE=system-bootstrap) so I forced using bundled one there too. that's unfortunate, but is more stable. not that we are using blobs, just bundled stuff, it's still built from source.