search

gentoo / dlang

[MIRROR] D programming language ebuild repository
https://gitweb.gentoo.org/repo/user/dlang.git
GNU General Public License v2.0
30 stars 25 forks source link

gdc shorten USE flags to gdc-SLOT #126

Closed the-horo closed 10 months ago

the-horo commented 10 months ago

Since gcc will keep ABI compatibility on a given stabilized branch, it is enough to depend only on a gcc branch (slot), rather than a full version. This simplifies gdc USE flags a lot and maintaining them becomes easier.

@ArsenArsen

ArsenArsen commented 10 months ago

thanks! :-)

i can't do code review right now, though

the-horo commented 10 months ago

Yes, gdmd and the gdc USE flags in dlang-compilers.eclass should have the same keywords, which are derived from the keywords of gcc. Were I to split the eclass changes in 2 commits I would have had to remove gdc-13* as an USE flag, make the changes, and then add gdc-13 with the proper keywords.

If you are referring to general stabilization, so far we have been matching whatever keywords gcc has (excluding hppa and sparc) and assume that everything will work regardless or arch. I could either drop the keywords that I don't test and leave only amd64, x86 and arm64 or unstable all keywords, in case the changes end up breaking something. Then they can be stabilized after some time like any other pakcage.

ArsenArsen commented 10 months ago

sure, that's fine by me. I just didn't realize whether it's intentional so I figured I should ask.

the-horo commented 10 months ago

Alright then, I'll wait a little bit more to see if @mleise has any comments but if it takes to long I'll go ahead and merge it myself.