search

gentoo / dlang

[MIRROR] D programming language ebuild repository
https://gitweb.gentoo.org/repo/user/dlang.git
GNU General Public License v2.0
30 stars 25 forks source link

ldc2-1.24.0 line 21: Was expecting token "string". Got ',' instead. #85

Closed Alessandro-Barbieri closed 3 years ago

Alessandro-Barbieri commented 3 years ago

build log here https://gist.github.com/Alessandro-Barbieri/f935b3555416cafb479688db7ef37fe5

mleise commented 3 years ago

Hello Alessandro! It may be that the ldc2.conf format changed at some point. I'm not using hardened Gentoo. Does this error pop up with all current versions of the ldc ebuild or did it start with 1.24.0?

mleise commented 3 years ago

I already answered it myself. I'll remove the superfluous comma from all ebuilds. Thanks for reporting the issue.

mleise commented 3 years ago

Can you help me out here and test if the build completes if you remove the superfluous comma from the ebuilds where it says: detect_hardened && mycmakeargs+=( -DADDITIONAL_DEFAULT_LDC_SWITCHES=', "-relocation-model=pic"' )? On my end I get the error ldc2: for the --relocation-model option: Cannot find option named 'pic-link-defaultlib-shared'! and if that's the same on hardened, you'd have to fix the ebuild yourself and provide the patch.

Alessandro-Barbieri commented 3 years ago

Try this: -DADDITIONAL_DEFAULT_LDC_SWITCHES=' "-relocation-model=pic", ' it seems to work

mleise commented 3 years ago

Haha, I see my mistake now. Thank you it works now for me. Will be fixed in the next update!