search

gentoo / gentoo-zsh-completions

[ORIGIN] Gentoo specific zsh completion support (ebuild, emerge, eselect, ...)
Other
36 stars 19 forks source link

Replace 'upgradeonly' with 'changed-use' #31

Closed gbrlsnchs closed 1 year ago

gbrlsnchs commented 1 year ago

Fixes #30.

thesamesam commented 1 year ago

@msva

gbrlsnchs commented 1 year ago

As a side note, I tested this PR locally by patching gentoo-zsh-completions using /etc/portage/patches.

msva commented 1 year ago

Looks pretty valid. I'll test it and will merge it shortly.

msva commented 1 year ago

@gbrlsnchs sorry, I forgot to ask you to add Signed-off-by (git commit -s) as by GLEP76 https://www.gentoo.org/glep/glep-0076.html

Can you, please, re-create a PR with commit with Signed-off-by?

msva commented 1 year ago

@gbrlsnchs or, alternatively, if you don't want to sign-off, but don't mind, I can commit it on my own, and add a credit to you nd this PR in commit message.

gbrlsnchs commented 1 year ago

@msva No worries. Coincidentally I started signing off my commits but by the time I opened this PR I wasn't yet.