gentoo / tatt

[MIRROR] arch testing tool
https://gitweb.gentoo.org/proj/tatt.git
GNU General Public License v2.0
11 stars 14 forks source link

handle ALLARCHES packages specially #60

Closed DerDakon closed 3 years ago

DerDakon commented 5 years ago

Something marked ALLARCHES for me usually means "I'll ignore it and let the maintainer stabilize it for everyone". If you are the maintainer for you this would probably mean "I need a different commit script". Currently ALLARCHES packages aren't handles specially in any way, which smells like it is always wrong.

leio commented 5 years ago

ALLARCHES I take to mean "if I'm the first arch team to handle this stable request, I'll stabilize it for all the arches CCed, not just my own"

DerDakon commented 5 years ago

Which is the second case and is fine.

thesamesam commented 4 years ago

I think we need GLEP 72 to be implemented to do this right (or just have ekeyword implement it).

mjeveritt commented 4 years ago

I think one could propose a patch to implement the suggested functionality, and get council (possibly QA) to ratify it, then commit the patch, and off-we-go ?

kensington commented 4 years ago

ALLARCHES I take to mean "if I'm the first arch team to handle this stable request, I'll stabilize it for all the arches CCed, not just my own"

This is correct.

I think we need GLEP 72 to be implemented to do this right (or just have ekeyword implement it).

I don't think we need to wait for this - an architecture need not be stable to make use of stable keywords.

I think one could propose a patch to implement the suggested functionality, and get council (possibly QA) to ratify it, then commit the patch, and off-we-go ?

This can be implemented as soon as a patch is available. No external approval is required.

thesamesam commented 3 years ago

nattka handles this for us now, excellent! Note that the council already ratified ALLARCHES: https://gitweb.gentoo.org/data/glep.git/commit/?id=6f4d97c0db20af6e3d75063b118f3756983a589a.

DerDakon commented 3 years ago

That probably means one would need to use nattka in the commit script, right? Can you provide an example or a patch?

thesamesam commented 3 years ago
$ cat ~/templates/commit-snippet
pushd @@CP@@ > /dev/null

nattka apply -a @@ARCH@@ @@BUG@@
nattka commit -a @@ARCH@@ @@BUG@@

popd > /dev/null
$ cat ~/templates/commit-snippet-2
# Code for checking consistency of @@EBUILD@@
pushd @@CP@@ > /dev/null

repoman -d full || exit 1
nattka resolve -a @@ARCH@@ @@BUG@@

popd > /dev/null