search

gentooboontoo / js-quantities

JavaScript library for quantity calculation and unit conversion
http://gentooboontoo.github.io/js-quantities/
MIT License
396 stars 102 forks source link

Missing gauge as length unit #149

Open jeromevalentin opened 1 month ago

jeromevalentin commented 1 month ago

Gauge unit is used in US to measure really thick products like plastic film.

As defined here: [gauging.com] (https://www.gauging.com/customer-resources/film-calculators/plastic-gauge-thickness-chart/)

100 gauge = 1 mil = 0.0000254 m

glepretre commented 1 month ago

The problem with Gauge is that each profession has its own gauge unit to measure anything and everything. This would be impossible to implement correctly unless you named each "gauge" precisely.

Have a look a the list here: https://en.wikipedia.org/wiki/Gauge. The plastic film use case is not there by the way.

I guess your need would be to add it to the library as "custom" unit: https://github.com/gentooboontoo/js-quantities/issues/96

It seems that unitmath supports it :wink:

jeromevalentin commented 1 month ago

@glepretre Thanks for your comment ! You are right such "missing units" are probably business dependant.

So the remaining question is:

When the possibility to define custom unit will be really added to the main library?

The PR (https://github.com/gentooboontoo/js-quantities/pull/112) is still not integrated 3 years after .... what is blocking the integration process?

We can see that the feature is really missing and some developers are starting to fork to integrate this PR ... (like https://github.com/philippspohn/js-quantities/commit/a55472f8eb0550e53dc7ae2cec39f5fc5dd4a78e).

Should we stop using @gentooboontoo version ?

Thanks in advance for any hints.

glepretre commented 1 month ago

When the possibility to define custom unit will be really added to the main library?

When @gentooboontoo will be convinced of the benefits of this feature compared to the drawbacks: for example as long as it is not possible, users ask for the addition of new units in the library, often legitimate.

But if a clean and convincing Pull Request was made, for example by also documenting the fact of continuing to ask for the addition of units recognized as missing; with tests, etc. I think we could convince @gentooboontoo.

The PR (https://github.com/gentooboontoo/js-quantities/pull/112) is still not integrated 3 years after .... what is blocking the integration process?

The PR has been closed by its author, after the first review.

We can see that the feature is really missing and some developers are starting to fork to integrate this PR

The issue https://github.com/gentooboontoo/js-quantities/issues/96 is still open to discuss and suggest a new PR.

Should we stop using @gentooboontoo version ?

It's open-source: you can do whatever you want :sweat_smile: As a developer I would recommend to contribute to this library because it's still maintained by @gentooboontoo but you can you another one, or fork, but this would not profit to the js-quantities users :slightly_smiling_face: