search

gentooboontoo / js-quantities

JavaScript library for quantity calculation and unit conversion
http://gentooboontoo.github.io/js-quantities/
MIT License
396 stars 102 forks source link

Correcting the units of force #18

Closed Chris-Cunningham closed 10 years ago

Chris-Cunningham commented 10 years ago

Force is a kg*m/s^2, so it should be 8000 + 1 - 20 - 20 = 7961. Previously it was listed as 7981, which meant that we got the strange behavior of a Newton-second having kind() equal to "force."

rage-shadowman commented 10 years ago

If you can add a unit test to the "spec/quantitiesSpec.js" file (unit tests that fail with the current code and prove this is a bug) that will help make sure this bug doesn't sneak back in.

Chris-Cunningham commented 10 years ago

I'm not sure if I've done it correctly, but I tried my best. I think it is in the right spot. Thanks!

gentooboontoo commented 10 years ago

Oups, I have added your commit and the test myself into master too soon. I am going to revert and merge your whole pull request.

Chris-Cunningham commented 10 years ago

Go ahead however you like; thanks for your help!

gentooboontoo commented 10 years ago

Thank you @Chris-Cunningham :thumbsup: (and thank you too @rage-shadowman to have answered this PR).