search

gentooboontoo / js-quantities

JavaScript library for quantity calculation and unit conversion
http://gentooboontoo.github.io/js-quantities/
MIT License
396 stars 102 forks source link

memory speed units and plural for memory units #44

Closed beradrian closed 9 years ago

beradrian commented 9 years ago

Fix for issue #42 and #43.

gentooboontoo commented 9 years ago

Thank you. Could you split your changes in two commits (memory plurals then memory speeds)?

beradrian commented 9 years ago

I split the changes into different commits as you requested.

beradrian commented 9 years ago

How should I add memory_speed to SIGNATURE_VECTOR and KINDS?

beradrian commented 9 years ago

Here's an example http://plnkr.co/edit/mHjLqo0p5mhv8KPdI785?p=preview

beradrian commented 9 years ago

I renamed memory to information and memory_speed to information-rate. What about my question regarding SIGNATURE_VECTOR and KINDS?

gentooboontoo commented 9 years ago

You don't have to change SIGNATURE_VECTOR. Just add "25599999980": "information_rate" to KINDS (definitively use underscore for kinds, not dash, sorry for the inconvenience).

Please also include tests about bps/Bps and kind.

beradrian commented 9 years ago

I added "information_rate" to KINDS and replaced dash with underscore. I saw no tests for memory/information. Are you sure you want me to add for information_rate?

gentooboontoo commented 9 years ago

Merged. I have rebased your commits and refactored tests. Thank you.