search

gentooboontoo / js-quantities

JavaScript library for quantity calculation and unit conversion
http://gentooboontoo.github.io/js-quantities/
MIT License
396 stars 102 forks source link

ES6 module support on 1.6.4 breaks builds without ES6 support/transpiling (bower.json - main needs to be updated) #77

Closed cheung31 closed 7 years ago

cheung31 commented 7 years ago

For those with a js-quantities dependency configured to ~1.6.3 this patch release will break builds if transpiling to ES6 is not a part of the build pipeline.

Perhaps v1.6.4 release should be a major release?

gentooboontoo commented 7 years ago

Despite the overhaul, it was not expected to break. build/quantities.js is intended to remain ES5 compatible. I was unsure about updating patch or minor but I finally chose patch since there was only a fix and no new feature.

I can't check for the moment, which specific part is breaking ?

cheung31 commented 7 years ago

@gentooboontoo Ah, I see. I am using Bower to manage my js-quantities dependency. Looks like you need to update the main in bower.json to point to build/quantities.js as opposed to src/quantities.js

gentooboontoo commented 7 years ago

Fixed in 86b8b58d8a9ec6f65c15b1e082c21f5bfc4271ac