search

gentooboontoo / js-quantities

JavaScript library for quantity calculation and unit conversion
http://gentooboontoo.github.io/js-quantities/
MIT License
396 stars 102 forks source link

Support for Barrels volume types, plus imperial versions of gallons, fl oz, pints, quarts #97

Closed sheam closed 5 years ago

sheam commented 5 years ago

I add definitions and tests for Imperial Gallons, and Barrels for the US, Imperial, and Oil. I did basically the same pull request for Units.Net a while ago.

gentooboontoo commented 5 years ago

Thanks! Merged by 68d930a427c3bb1296875f7a6f8b2221479d01ed.

For information, I have cleaned up the commits by removing .idea/ files committed by mistake, adding a small fix to fluid ounce definition and removing added tests which were not very useful here.

sheam commented 5 years ago

Thanks Julien.

On Sun, Jun 23, 2019 at 3:28 PM Julien Sanchez notifications@github.com wrote:

Thanks! Merged by 68d930a https://github.com/gentooboontoo/js-quantities/commit/68d930a427c3bb1296875f7a6f8b2221479d01ed .

For information, I have cleaned up the commits by removing .idea/ files committed by mistake, adding a small fix to fluid ounce definition and removing added tests which were not very useful here.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/gentooboontoo/js-quantities/pull/97?email_source=notifications&email_token=AANSMC5BLNWFCWMQ3SWAGK3P37TH3A5CNFSM4H2DDLC2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYLHODQ#issuecomment-504788750, or mute the thread https://github.com/notifications/unsubscribe-auth/AANSMC2B2QSUQU3JPFAFDH3P37TH3ANCNFSM4H2DDLCQ .