gentzkow / GentzkowLabTemplate

MIT License
1 stars 3 forks source link

Plans for substantive next steps for template development #16

Open ShiqiYang2022 opened 2 months ago

ShiqiYang2022 commented 2 months ago

The goals of this issue are:

I am assigning myself to address this.

ShiqiYang2022 commented 2 months ago

@gentzkow

I have thought carefully about the next steps you've drafted in Roadmap and https://github.com/gentzkow/GentzkowLabTemplate/pull/14#issuecomment-2285161889, and I make some notes on how I envision to address those items, which are pulled into the .lyx document here in the branch. It would be great if we can converge on how to implement those in that document.

I also plan to use this issue and its branch for supervision purpose, like what we do in production. After we converged in the lyx document, we can ask labmates and ourselves to open the issue according to the document, address accordingly, and open a PR to merge to this issue branch. Then we merge back this branch to master to complete this round of development.

I'd appreciate if I can hear your thoughts on the plans and the workflow. Thanks!

gentzkow commented 2 months ago

@ShiqiYang2022 Thanks so much for taking the initiative on this! I think the most efficient thing would be to have a meeting w/ the whole predoc team to talk through these issues and make a plan. Rather than trying to create a plan for all of them, I'd suggest we try to make a plan for the first 5 or so -- enough to keep the team busy for a week at least -- then once those are done we revisit the next batch. (I think the first batch may change what we want to do on subsequent to dos so it's efficient to be sequential.) Maybe you can send around an email to schedule.

ShiqiYang2022 commented 2 months ago

@gentzkow Thanks! I agree with https://github.com/gentzkow/GentzkowLabTemplate/issues/16#issuecomment-2337092177, I will send a email today to schedule some time later this week to meet, after Luca finish his onboarding and both Luca and Linxi have familiarized themselves in #15.

lucamlouzada commented 2 months ago

Hi @ShiqiYang2022, I just added some comments to your .lyx document here in https://github.com/gentzkow/GentzkowLabTemplate/commit/2d9cb1dcd84b91fcdf5e4f7401bfd18a349f9a55 per our discussion in #15.

ShiqiYang2022 commented 2 months ago

Update: I have revised nextstep.lyx to reflect our decision from last group meeting. I seperate the part we have reached agreement into a new section in the .lyx document.

The file will be further updated to reflect our decision in tomorrow's meeting. For the places we have reached agreement, we should go ahead, open the issues, and then assign ourselves to address. Also, feel free to edit and correct me if I've written something incorrectly.

cc: @Xingtong-Jiang @lucamlouzada @linxicindyzeng

ShiqiYang2022 commented 1 month ago

Update: I have revised nextstep.lyx to reflect our decision from last group meeting. I moved the part we have reached agreement into "Resolved points with plans" section in the .lyx document, and the part that we should revisit later into "Points now on the shelf and revisit later" section.

Feel free to weigh in and correct me if I've written something incorrectly.

cc: @Xingtong-Jiang @lucamlouzada @linxicindyzeng

lucamlouzada commented 2 weeks ago

Hi @linxicindyzeng ,

Per discussion with @ShiqiYang2022 , we think it would be great if you could assist us with this issue, especially focusing on #21. Now that @ShiqiYang2022 has reviewed #19, I'll also open PRs soon for most of the other issues and then it would be great it you could help with reviewing those. But in the meantime, do you think you could take a look at what I wrote in #21, and @gentzkow 's reply, and then look into what you think is the best approach, especially for Stata as mentioned by him? Thanks!

lucamlouzada commented 1 week ago

Note: as we have merged several changes to the main branch, I have made a minor change in the Wiki to reflect the new approach of get_inputs.sh (#27). There will be more changes to the wiki and to READMEs in the future but I thought this one was important in case anyone is starting to use the template now.