search

gentzkow / GentzkowLabTemplate

MIT License
1 stars 3 forks source link

PR for #15: Familiarize yourself with new lab template #17

Closed lucamlouzada closed 2 months ago

lucamlouzada commented 2 months ago

Closes: Issue #15. Merges issue branch with main.

In this issue we noted some minor improvements to the new lab template.

Changes in this branch:

Deliverables:

@ShiqiYang2022, can you please review? Thanks!

lucamlouzada commented 2 months ago

Thanks @ShiqiYang2022 , just confirmed your change ran in my Windows as well so I went ahead and merged. Will add the summary to the closed issue.

ShiqiYang2022 commented 2 months ago

@lucamlouzada Thanks so much for closing this PR! Everything looks great to me.

I have two minor comments about our workflow, those are documented in our predoc manual - workflow.

It's hard to always remember what's written in the manual at the beginning, so it would be a good experience learning by doing (like this PR!).

ShiqiYang2022 commented 2 months ago

Another note: Now that the changes are brought to master, would it be convenient for you to update the branches accordingly? Thanks!

lucamlouzada commented 1 month ago

Thanks @ShiqiYang2022 , I'll pay attention to those points next time. I have updated the relevant branches in 09c1f574 for branch 16, and also for branch 18. Could you please quickly revise and provide feedback on whether this was done correctly? Thanks again for all your help.

ShiqiYang2022 commented 1 month ago

@lucamlouzada All looks great to me, thanks!!