gentzkow / GentzkowLabTemplate

MIT License
0 stars 2 forks source link

PR for #18: Improve error handling #19

Open lucamlouzada opened 1 week ago

lucamlouzada commented 1 week ago

Closes #18.

Changes and deliverables: In issue #18, I made significant changes to the way errors are handled in the lab template. These changes were pushed in one commit per file, as follows:

A more detailed explanation for the changes is written in https://github.com/gentzkow/GentzkowLabTemplate/issues/18#issuecomment-2359557206.

Review: These are significant changes and therefore require a careful and thorough review. My suggested framework for review is as follows:

To test the behavior of error handling, force some errors as follows:

I am assigning either @ShiqiYang2022 , @Xingtong-Jiang , or @linxicindyzeng to review.

ShiqiYang2022 commented 1 week ago

Just a note for our workflow for peer reviews in template development and other projects that have >=2 RAs:

I am requesting @Xingtong-Jiang, @linxicindyzeng and myself as initial reviewers. Whoever come first to review this pull request should remove the request from other labmates, and post a comment here indicating the peer review is in progress.

After the labmates sign off for this PR, we will invite Matt to review this PR.

Xingtong-Jiang commented 6 days ago

Hi all, I’ll take on the initial review for this PR. I’m removing the request from other labmates and starting the review.

ShiqiYang2022 commented 1 day ago

Per conversation with @Xingtong-Jiang, I can take over this PR.

lucamlouzada commented 19 hours ago

Thanks @ShiqiYang2022 ! Note that I just pushed some updates discussed in https://github.com/gentzkow/GentzkowLabTemplate/issues/18#issuecomment-2380285621.