PR for #3: Try to break the template

gentzkow / GentzkowLabTemplate

MIT License

0 stars 2 forks source link

PR for #3: Try to break the template #7

Closed ShiqiYang2022 closed 5 months ago

ShiqiYang2022 commented 6 months ago

Closes #3.

In #3, we tried many tests to break our current template and implement the fixes. The goal of this PR includes:

[x] Re-run the template on Mac following the README file, report and fix any errors if any.
[x] Carefully review the code changes and make sure all make sense.
[x] Examine the dependencies to make sure there is no stray files that are no longer referenced, if any, please delete them.

I am requesting @shrishj as initial reviewer, while I am also testing on my own end. Will consider to loop in Matt and other lab members when the time comes.

Thanks in advance for the review!

shrishj commented 6 months ago

Hi @ShiqiYang2022. Thanks for your message. I am working through the bullet points listed in your initial message. I think there are a few issues with the README, particularly over here.

I think that the structure of the repo has changed since the initial porting of files when the README was created. An example would be the lines referencing 1_data/source/make.shand 2_analysis/source/make.sh. I do not think that the make.sh exists in these folders. I can make the change on the README.
In reference to these lines, I do not see any lines that are commented out. Shall we remove these lines from the README?

Please let me know if you agree with the above two points and I will make the change on the README. Thanks!

ShiqiYang2022 commented 6 months ago

@shrishj Thanks very much!

For 1, definitely feel free to go ahead and implementing the changes!

For 2, it seems like I cannot find the navigation of your link?

shrishj commented 6 months ago

Hi @ShiqiYang2022. Apologies for the link for bullet point 2. I am referring to the Setup section where there are a few lines regarding using template with R and Stata.

ShiqiYang2022 commented 6 months ago

@shrishj Great thanks! I think it is safe for you to go ahead with your proposed edits, we can always try to think about adding those back.

shrishj commented 6 months ago

Hi @ShiqiYang2022. I have pushed a new commit that addresses the two bullet points we spoke about above, which means I made changes to the README file.. From my personal review, I believe that we are meeting the three to-do tasks set in the initial message. Thanks.

ShiqiYang2022 commented 6 months ago

@shrishj Thanks! Would it be convenient for you to push your log files for replication running to this branch?