gentzkow / template_archive

20 stars 36 forks source link

Update to Python 3.10 #65

Closed jc-cisneros closed 2 years ago

jc-cisneros commented 2 years ago

The goal of this issue is to update the Python version used in master. The steps are the following:

cc. @gentzkow @snairdesai

jc-cisneros commented 2 years ago

The repository ran successfully with Python 3.10. Some considerations to have in mind:

Screen Shot 2022-10-07 at 11 26 17 AM

Per https://github.com/gentzkow/CommitFlex/issues/114#issuecomment-1270855660, we should not be using any packages that don't work with 3.10+. As the linearmodels is required in template, I will work on debugging the error.

@gentzkow @snairdesai I would appreciate your input on the following proposed steps:

snairdesai commented 2 years ago

Thanks @jc-cisneros! For some reason the link you pasted gives me an "invalid credentials" error. It doesn't seem like any updates have been made to our original shared document?

Screen Shot 2022-10-07 at 3 14 26 PM
snairdesai commented 2 years ago

@jc-cisneros The edits above look good to me, I think we can add to the Proposed Changes document! I know we have open issues for integrating other revisions from this document to template and lab-manual, maybe we can regroup on resolving those PRs.

gentzkow commented 2 years ago

Thanks @jc-cisneros. Proposed changes sound great.

The lab-manual permissions were just a glitch. Everyone in the gslab RA group now has write access (including you!).

jc-cisneros commented 2 years ago

Update: The error with linearmodels was fixed in f98a2b4.

@snairdesai it is odd that you are getting that "invalid credentials" error. If you are logging in with your Stanford account, then I don't know what may be causing it. Fortunately, the link you shared takes me to the same document.

@gentzkow thanks! I think then the best way to proceed is to open new issues in both repositories and cross-reference the changes. @snairdesai and I can work on that after PR for #18 is closed.

For the moment, I will proceed with the PR on #66.

jc-cisneros commented 2 years ago

Summary:

On this issue, the Python version used by template was updated to 3.10. We also decided to add an extra step regarding listing the package version (see https://github.com/gentzkow/template/issues/65#issuecomment-1271955569).

Changes to master were brought by #66.