Closed jc-cisneros closed 2 years ago
The repository ran successfully with Python 3.10. Some considerations to have in mind:
conda config --set channel_priority strict
should be added to the template ReadMe to save a nontrivial amount of time (this is already part of our Proposed Changes).conda_env.yaml
file. Running conda list
returns the version of all packages being used. I am working to find a way to return only the smallest working subset of those (i.e., the other packages are their dependencies). linearmodels
package has not been commented out. This is due to the fact that the latest version of this package does not work with the current code in template
(see error below).Per https://github.com/gentzkow/CommitFlex/issues/114#issuecomment-1270855660, we should not be using any packages that don't work with 3.10+. As the linearmodels
is required in template
, I will work on debugging the error.
@gentzkow @snairdesai I would appreciate your input on the following proposed steps:
conda_env.file
), I will add this instruction in the Proposed Changes working document. template
and the RA Manual
(template
references the RA Manual
). What should be the approach to bringing those changes to these two repositories? @snairdesai and I currently don't have contributor status in gslab-econ/lab-manual
.Thanks @jc-cisneros! For some reason the link you pasted gives me an "invalid credentials" error. It doesn't seem like any updates have been made to our original shared document?
@jc-cisneros The edits above look good to me, I think we can add to the Proposed Changes document! I know we have open issues for integrating other revisions from this document to template
and lab-manual
, maybe we can regroup on resolving those PRs.
Thanks @jc-cisneros. Proposed changes sound great.
The lab-manual
permissions were just a glitch. Everyone in the gslab RA group now has write access (including you!).
Update: The error with linearmodels was fixed in f98a2b4.
@snairdesai it is odd that you are getting that "invalid credentials" error. If you are logging in with your Stanford account, then I don't know what may be causing it. Fortunately, the link you shared takes me to the same document.
@gentzkow thanks! I think then the best way to proceed is to open new issues in both repositories and cross-reference the changes. @snairdesai and I can work on that after PR for #18 is closed.
For the moment, I will proceed with the PR on #66.
Summary:
On this issue, the Python version used by template
was updated to 3.10. We also decided to add an extra step regarding listing the package version (see https://github.com/gentzkow/template/issues/65#issuecomment-1271955569).
Changes to master were brought by #66.
The goal of this issue is to update the Python version used in
master
. The steps are the following:setup/conda_env.yaml
file, so that the norm is that the user updates to the latest version. Update the readme file to reflect current setup.cc. @gentzkow @snairdesai