search

gentzkow / template_archive

19 stars 36 forks source link

PR for #65 Update to Python 3.10 #66

Closed jc-cisneros closed 2 years ago

jc-cisneros commented 2 years ago

Closes #65.

This issue updates the Python version in the template conda environment to 3.10. There was also a minor fix in the code to make it compatible with the latest version of linearmodels.

@gentzkow I will add @snairdesai as a reviewer.

@snairdesai I also want to flag that we should incorporate these changes to #61 .

jc-cisneros commented 2 years ago

@snairdesai I removed the print statement in the latest commit. Let me know if there are any other changes that should be addressed.

snairdesai commented 2 years ago

Thanks @jc-cisneros! I successfully re-ran it just now, looks good to me.