gentzkow / template_archive

20 stars 36 forks source link

PR for #71 Log software + packages versions #72

Closed jc-cisneros closed 2 years ago

jc-cisneros commented 2 years ago

This pull request closes https://github.com/gslab-econ/gslab_make/issues/56 and https://github.com/gentzkow/template/issues/71. This template branch is currently pulling the 56-version-log branch of the gslab_make submodule, so https://github.com/gslab-econ/gslab_make/pull/56 should be closed first.

The steps to test the new feature are the following:

Once the tests are successful, we can proceed to merge the 56-version-log branch of gslab_make to master, point the submodule to master and run the entire repo again.

I'm adding @snairdesai as a reviewer.

cc. @gentzkow

snairdesai commented 2 years ago

@jc-cisneros I've just finished testing this on the specified branch. Noting I deleted the cached version of my template environment and rebuilt from scratch in case any changes had been made to packages. Everything seems to work from my end. The only minor thing is there are some misalignments in the printing of versions for some of the longer package/build names. This is a small aesthetic detail we may consider fixing (for example, by adding more blank space between columns).

Screen Shot 2022-11-13 at 3 37 31 PM

Thanks for the work - I'll proceed to the code review now!