AkihiroSuda commented 5 years ago

shadow-maint/shadow#138 caused a regression reported in genuinetools/img#191.

Temporarily fork shadow again until shadow-maint/shadow#141 gets merged.

Signed-off-by: Akihiro Suda suda.akihiro@lab.ntt.co.jp

@jessfraz @giuseppe

codecov[bot] commented 5 years ago

Codecov Report

Merging #194 into master will not change coverage. The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #194   +/-   ##
=====================================
  Coverage       0%     0%           
=====================================
  Files          13     13           
  Lines         740    740           
=====================================
  Misses        740    740

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7c58387...f418af3. Read the comment docs.

giuseppe commented 5 years ago

LGTM!

jessfraz commented 5 years ago

thanks!

giuseppe commented 5 years ago

and it can be reverted again :smile:

AkihiroSuda commented 5 years ago

Thanks, https://github.com/genuinetools/img/pull/196

genuinetools / img

Fork shadow again temporarily #194

Codecov Report