genzj / pybingwallpaper

Download wallpaper from bing.com
MIT License
547 stars 103 forks source link

use n=1 instead of n=10 for more backtracking room #15

Closed genzj closed 10 years ago

genzj commented 10 years ago

Sorry, I have another request.

HPImageArchive allows values of idx until value of 19. It errors if idx>19. "n" is the number of days returned after the value of idx. If n=1 it always gives good information. But if the sum of "idx" plus "n" is greater than 23 returned filenames are not what they should be.

Pybingwallpaper uses always n=10, but only treats first filename returned so it useless to have n=10. Then should be enough n=1.

If pybingwallpaper uses n=1 it could download wallpapers back to 19 days. Now (n=10) it only can download wallpapers back to 13 days (idx=13). From idx=14 to idx=19 always gives current day wallpaper, equivalent to idx=0. From 20 on it errors, like should be.

With n=1 one could have more 6 days backwards.

tks