geo-fluid-dynamics / peclet

An advection-diffusion solver written in C++ and based on deal.II
MIT License
3 stars 1 forks source link

Test parameter looks wrong #10

Closed agzimmerman closed 7 years ago

agzimmerman commented 7 years ago

I just noticed that the BC implementation types look wrong in peclet/tests/MMS_2D_VariableVelocity.prm.

Referring back to my master's thesis, the strong/Dirichlet boundary is the bottom (minimum y) boundary, while the rest are natural/Neumann. So we should have "implementation_types = natural, natural, strong, natural".

agzimmerman commented 7 years ago

Past Alex was correct. I was thinking of the wrong coordinate system directions.