search

geo-fluid-dynamics / phaseflow-fenics

Phaseflow simulates the convection-coupled melting and solidification of phase-change materials.
MIT License
52 stars 23 forks source link

Refactor octadecane.py to make the buoyancy model extensible #242

Closed agzimmerman closed 6 years ago

agzimmerman commented 6 years ago

Right now the buoyancy function is defined within phaseflow.octadecane.Simulation.update_governing_form, so this cannot be easily extended with other buoyancy models.

agzimmerman commented 6 years ago

Of course the name octadecane.py is too restrictive. This refers to how thermal conductivity and heat capacity are not changing between phases. But now we want to apply the same model to water, with only changing the buoyancy function. Since thermal conductivity and heat capacity changes significantly between liquid water and water ice, there will be a modeling error. Still, it is a useful water model for some applications.

agzimmerman commented 6 years ago

Perhaps it would simplify everything for first complete issue "Temperature-dependent material properties #193", so that the octadecane benchmark would just be a parameter choice.

agzimmerman commented 6 years ago

Completed with PR #245