Swiss summits are shifted in location search

ltbam commented 8 years ago

Search Matterhorn in map.geo.admin.ch and take the summit from the result. You will see the pin point is shifted from the summit. I dont know which scope this problem has but you can easily see all other summits shifted too.

https://map.geo.admin.ch/?topic=ech&lang=fr&bgLayer=ch.swisstopo.pixelkarte-farbe&layers=ch.swisstopo.zeitreihen,ch.bfs.gebaeude_wohnungs_register,ch.bav.haltestellen-oev,ch.swisstopo.swisstlm3d-wanderwege&layers_visibility=false,false,false,false&layers_timestamp=18641231,,,&X=91689.60&Y=617437.81&zoom=10

mariokeusen commented 8 years ago

In the swissnames3D visualization it seems to be correct: https://map.geo.admin.ch/?topic=ech&lang=de&bgLayer=ch.swisstopo.pixelkarte-grau&X=156583.79&Y=642957.65&zoom=10&layers=ch.swisstopo.swissnames3d&swisssearch=moench

gjn commented 8 years ago

It's the position of the label on lk10 that is displayed. This was triggered by a data update where we replaced part of the gazetter entries from tlm entries to lk10 entries.

I agree that for mountain peeks, this is sub-optimal.

@davidoesch ?

davidoesch commented 8 years ago

Reason is: the search results points now the center of the label in LK 10 for results whcih are visible in LK10

@ltclm : proposal/Discussion - for all point features we center not on the label but on the geometrie based on swissnames3d.

ltclm commented 8 years ago

exceptions are always welcomed :-) We have the following tlm objekart and objektklasse data distribution in the lk10 data delivery [1]. We have to use this information for the selection of the geometry source.

So we can now decide again if we want to

use annotation position for all features
make a objektart/objektklasse dependant choose of the geoemetry source

If we choose the latter option, somebody has to prepare the list of objektart,objektklasse features where we have to use the feature geometry. I think TLM_NAME_PKT would be a good start.

[1]

$ psql -c "select objektklasse,objektart,count(1) from tlm.swissnames3d_dkm10_blacklist group by  o    bjektklasse,objektart order by 1,2;" -d stopo_master
      objektklasse       |            objektart            | count
-------------------------+---------------------------------+--------
 TLM_AUS_EINFAHRT        | Ausfahrt                        |    758
 TLM_AUS_EINFAHRT        | Ein-_und_Ausfahrt               |     39
 TLM_AUS_EINFAHRT        | Verzweigung                     |    124
 TLM_BODENBEDECKUNG      | See                             |   1117
 TLM_EINZELOBJEKT        | Bildstock                       |     31
 TLM_EINZELOBJEKT        | Denkmal                         |     32
 TLM_EINZELOBJEKT        | Grotte_Hoehle                   |     62
 TLM_EINZELOBJEKT        | Landesgrenzstein                |      1
 TLM_EINZELOBJEKT        | Quelle                          |     40
 TLM_EISENBAHN           | Normalspur                      |     92
 TLM_EISENBAHN           | Schmalspur                      |     46
 TLM_FLIESSGEWAESSER     | Bisse_Suone                     |     98
 TLM_FLIESSGEWAESSER     | Fliessgewaesser                 |  14232
 TLM_FLURNAME            | Flurname_swisstopo              |  44693
 TLM_FLURNAME            | Lokalname_swisstopo             | 128328
 TLM_FREIZEITAREAL       | Campingplatzareal               |    374
 TLM_FREIZEITAREAL       | Freizeitanlagenareal            |     24
 TLM_FREIZEITAREAL       | Golfplatzareal                  |    125
 TLM_FREIZEITAREAL       | Pferderennbahnareal             |      8
 TLM_FREIZEITAREAL       | Sportplatzareal                 |     18
 TLM_FREIZEITAREAL       | Standplatzareal                 |     90
 TLM_FREIZEITAREAL       | Zooareal                        |     65
 TLM_GEBAEUDE            | Bruecke_gedeckt                 |      4
 TLM_GEBAEUDE            | Gebaeude_Einzelhaus             |   5453
 TLM_GEBAEUDE            | Historische_Baute               |      1
 TLM_GEBAEUDE            | Offenes_Gebaeude                |     66
 TLM_GEBAEUDE            | Sakraler_Turm                   |     16
 TLM_GEBAEUDE            | Sakrales_Gebaeude               |    115
 TLM_GEBIETSNAME         | Gebiet                          |    761
 TLM_GELAENDENAME        | Gletscher                       |    840
 TLM_GELAENDENAME        | Graben                          |   2862
 TLM_GELAENDENAME        | Grat                            |   1509
 TLM_GELAENDENAME        | Tal                             |   1281
 TLM_HALTESTELLE         | Haltestelle_Bahn                |   2446
 TLM_HALTESTELLE         | Haltestelle_Schiff              |    311
 TLM_HALTESTELLE         | Haltestelle_Uebrige_Bahnen      |    759
 TLM_MORPH_KLEINFORM_PKT | Erratischer_Block               |     24
 TLM_MORPH_KLEINFORM_PKT | Felsblock                       |     29
 TLM_NAME_PKT            | Alpiner_Gipfel                  |    312
 TLM_NAME_PKT            | Felskopf                        |    866
 TLM_NAME_PKT            | Gipfel                          |   2192
 TLM_NAME_PKT            | Hauptgipfel                     |   2499
 TLM_NAME_PKT            | Haupthuegel                     |    936
 TLM_NAME_PKT            | Huegel                          |   1837
 TLM_NAME_PKT            | Pass                            |   2095
 TLM_NAME_PKT            | Strassenpass                    |    120
 TLM_NUTZUNGSAREAL       | Friedhof                        |     36
 TLM_NUTZUNGSAREAL       | Historisches_Areal              |   1445
 TLM_NUTZUNGSAREAL       | Industrie_Gewerbeareal          |     13
 TLM_NUTZUNGSAREAL       | Kiesabbauareal                  |     68
 TLM_NUTZUNGSAREAL       | Klosterareal                    |     45
 TLM_NUTZUNGSAREAL       | Kraftwerkareal                  |    270
 TLM_NUTZUNGSAREAL       | Lehmabbauareal                  |      4
 TLM_NUTZUNGSAREAL       | Massnahmenvollzugsanstaltsareal |     59
 TLM_NUTZUNGSAREAL       | Messeareal                      |     21
 TLM_NUTZUNGSAREAL       | Oeffentliches_Parkareal         |    468
 TLM_NUTZUNGSAREAL       | Spitalareal                     |    393
 TLM_NUTZUNGSAREAL       | Steinbruchareal                 |     17
 TLM_NUTZUNGSAREAL       | Truppenuebungsplatz             |     31
 TLM_NUTZUNGSAREAL       | Unterwerkareal                  |     68
 TLM_SCHIFFFAHRT         | Personenfaehre_ohne_Seil        |      5
 TLM_SIEDLUNGSNAME       | Ort                             |  48520
 TLM_SIEDLUNGSNAME       | Ortsteil                        |    411
 TLM_SIEDLUNGSNAME       | Quartier                        |    917
 TLM_SIEDLUNGSNAME       | Quartierteil                    |   7297
 TLM_SPORTBAUTE_LIN      | Bobbahn                         |      1
 TLM_SPORTBAUTE_LIN      | Rodelbahn                       |     23
 TLM_SPORTBAUTE_LIN      | Skisprungschanze                |     10
 TLM_STAUBAUTE           | Staumauer                       |     82
 TLM_STRASSE             | 10m_Strasse                     |      2
 TLM_STRASSE             | 1m_Weg                          |     40
 TLM_STRASSE             | 1m_Wegfragment                  |      3
 TLM_STRASSE             | 2m_Weg                          |     25
 TLM_STRASSE             | 3m_Strasse                      |      9
 TLM_STRASSE             | 4m_Strasse                      |     22
 TLM_STRASSE             | 6m_Strasse                      |     34
 TLM_STRASSE             | 8m_Strasse                      |      6
 TLM_STRASSE             | Ausfahrt                        |      3
 TLM_STRASSE             | Autobahn                        |    370
 TLM_STRASSE             | Autostrasse                     |    167
 TLM_STRASSE             | Autozug                         |      5
 TLM_STRASSE             | Einfahrt                        |      1
 TLM_STRASSE             | Klettersteig                    |     31
 TLM_STRASSE             | Markierte_Spur                  |      4
 TLM_STRASSE             | Raststaette                     |      1
 TLM_STRASSE             | Zufahrt                         |      5
 TLM_STRASSENINFO        | Raststaette                     |    175
 TLM_STRASSENINFO        | Verladestation                  |      4
 TLM_VERKEHRSAREAL       | Fahrareal_privat                |     17
 TLM_VERKEHRSAREAL       | Flugfeldareal                   |     39
 TLM_VERKEHRSAREAL       | Flughafenareal                  |      3
 TLM_VERKEHRSAREAL       | Flugplatzareal                  |     17
 TLM_VERKEHRSAREAL       | Heliport                        |     23

davidoesch commented 8 years ago

I do hate exceptions -> TLM_NAME_PKT as centerpoint is a good start. (even then for DKM50 and 3D) if @gjin agrees, we go ahead with this

gjn commented 8 years ago

There are probably more that would make sense:

TLM_EINZELOBJEKT TLM_GEBAEUDE TLM_HALTESTELLE

On 24.06.2016 15:20, David Oesch wrote:

I do hate exceptions -> TLM_NAME_PKT as centerpoint is a good start. (even then for DKM50 and 3D) if @gjin [1] agrees, we go ahead with this

You are receiving this because you commented. Reply to this email directly, view it on GitHub [2], or mute the thread [3].

*

Links:

[1] https://github.com/gjin [2] https://github.com/geoadmin/mf-chsdi3/issues/2139#issuecomment-228343388 [3] https://github.com/notifications/unsubscribe/ACdAHcHx8zvF95cuqoA3GmcnJZ1PDKHoks5qO9msgaJpZM4I8opP

davidoesch commented 8 years ago

ok for

TLM_EINZELOBJEKT -TLM_GEBAEUDE

TLM_HALTESTELLE those ones are taken from BAV dataset..

gjn commented 8 years ago

@ltclm Could you try to update the sphinx query accordingly for these classes? Would be great to have it in next deploy.

ltclm commented 8 years ago

i have modified the data import script and i have updated the data and sphinx index in the dev environment. The following categories

TLM_NAME_PKT
TLM_EINZELOBJEKT
TLM_GEBAEUDE

are using the feature geometry now. testlink

gjn commented 8 years ago

Looks good Matterhorn [Hallenstadion](https://mf-geoadmin3.dev.bgdi.ch/?swisssearch=hallenstadion zürich%20limit:%201)

davidoesch commented 8 years ago

+1

gjn commented 8 years ago

@ltclm What needs to be done to have this on prod? Please keep @loicgasser in the loop for this.

ltclm commented 8 years ago

just deploy the following table tomorrow:

stopo_master.tlm.swissnames3d_dkm10_blacklist

I have added the table to the remember to deploy doc.

gjn commented 8 years ago

This is working well!

geoadmin / mf-chsdi3

Swiss summits are shifted in location search #2139

Links: