geoadmin / mf-geoadmin3

Legacy source code of map.geo.admin.ch
https://map.geo.admin.ch
Other
227 stars 72 forks source link

layers_timestamp parameter #1529

Closed gjn closed 9 years ago

gjn commented 10 years ago

In RE2, we had a layers_timestamp paremeter. Support it in RE3 with same behaviour as in RE2.

Note: in RE2, wie didn't have 'time' parameter as we have in RE3. Be careful that both parameters work together well, or maybe assure that only one of them can be active.

As 'layers_timestamps' is read-only in RE2, I propose the following:

oterral commented 9 years ago

Any example of permalink with this parameter?

loicgasser commented 9 years ago

http://map2.geo.admin.ch/?Y=561104&X=185325&zoom=11&bgLayer=voidLayer&layers=ch.kantone.cadastralwebmap-farbe,ch.kantone.cadastralwebmap-farbe&layers_opacity=1,0.8&layers_visibility=true,true&layers_timestamp=20121101,20120501

loicgasser commented 9 years ago

Found this one as well http://map2.geo.admin.ch/?Y=607189.31&X=204776.48&zoom=4&bgLayer=ch.swisstopo.pixelkarte-farbe&layers_timestamp=20130903&mobile=false&lang=de&topic=ech&layers=ch.swisstopo.pixelkarte-farbe-pk25.noscale,ch.swisstopo.vec200-landcover-wald,ch.bafu.showme-gemeinden_sturzprozesse,ch.blw.bodeneignung-gruendigkeit,ch.bafu.nabelstationen,ch.blw.niederschlagshaushalt&catalogNodes=532,628&layers_opacity=1,0.75,0.75,0.75,1,0.75

oterral commented 9 years ago

@cedricmoullet @davidoesch first implementation:

http://mf-geoadmin3.dev.bgdi.ch/dev_timestamp/?X=190000.00&Y=660000.00&zoom=1&lang=fr&topic=luftbilder&bgLayer=ch.swisstopo.pixelkarte-grau&catalogNodes=1179,1180,1186&layers=ch.swisstopo.lubis-luftbilder_schwarzweiss,ch.swisstopo.lubis-luftbilder_farbe&layers_timestamp=19981231,20031231

oterral commented 9 years ago

@cedricmoullet @davidoesch duplication of timeEnabled layer added: http://mf-geoadmin3.dev.bgdi.ch/dev_timestamp/?lang=fr&topic=luftbilder&bgLayer=ch.swisstopo.pixelkarte-grau&X=190000.00&Y=658250.00&zoom=1&catalogNodes=1179,1180,1186&layers_timestamp=19981231,20091231&layers=ch.swisstopo.lubis-luftbilder_schwarzweiss,ch.swisstopo.lubis-luftbilder_schwarzweiss

cedricmoullet commented 9 years ago

Thanks !!

  1. Buttons are too small, particularly on mobile. Any chance to make the "duplicate", "up" and "down" bigger and with more space ?
  2. Instead of a combobox for the "layer year", would it be possible to only show the year as a button (as inspiration http://getbootstrap.com/components/#badges ) we could save space and show "all" as default
  3. The element mentionned in point 2 should always be active (means, it's possible to change the year). If only one layer is active and the time slider is active, then it moves the time slider (and vice versa)
    • If only one layer is active and the time slider is not active and you change the year (from "all" to one year), then the time slider has to be actived.
    • If more than one layers are active, but all with the same year, than the time slider has to be active
    • If more than one layers are active, but with various years, then the time slider has to disappear
    • If time slider is activated and deactivated and activated again, the initial years of each layer has to be kept in order to avoid that the user looses his "settings"
    • For the duplicate icon, you can use http://fortawesome.github.io/Font-Awesome/icon/files-o/
    • In the year list, we should avoid to a have a scroller. David and I hope that thise makes sense. Is it doable ?
oterral commented 9 years ago
  1. Instead of a combobox for the "layer year", would it be possible to only show the year as a button (as inspiration http://getbootstrap.com/components/#badges ) we could save space and show "all" as default

Good idea for the badge display but how we display the list of year, do we keep the combo box?

For the duplicate icon, you can use http://fortawesome.github.io/Font->Awesome/icon/files-o/

Already ask to Paulo to update the font-awesome

In the year list, we should avoid to a have a scroller. David and I hope that thise >makes sense. Is it doable ?

I don't think it's possible with a default combobox

gjn commented 9 years ago

Nice!

Two things I noticed: 1) Tooltip is active for all objects of the layer, not only the active years. So we can see tooltip of 1973, even though only 1998 and 2010 is active 2) Search does find objects from other layers. Same setup as above will find objects from 1973 (search for 1973).

It might be that both these issues also need adaption in the back-end.

Edit: 3) Toggling the timeslider with 2 layers active has strange behaviour. When de-activating again, the combo-boxes are empty.

oterral commented 9 years ago

New version with new UI: a select box on mobile and a popup on desktop.

cedricmoullet commented 9 years ago

Tested on iPhone iOS 7 works fine. Transparency slider should be replaced.

Envoyé de mon iPhone

Le 8 oct. 2014 à 17:45, oterral notifications@github.com a écrit :

New version with new UI: a select box on mobile and a popup on desktop.

— Reply to this email directly or view it on GitHub.

davidoesch commented 9 years ago

Very nice,, did tests according to the testbook entry "timeCompare" https://docs.google.com/spreadsheet/ccc?key=0Alq30s3mf7gPdDRkMHdKeTBya0R5SXc5LUlleTlpN1E#gid=0

Improvement: use a red color for the font of the year (so it is in accordance with the time mode color...)

oterral commented 9 years ago

Always red or only red when TimeSlider is active?

davidoesch commented 9 years ago

Ok here you go unbenannt1

and unbenannt

this should be grey

unbenannt2

and here we have an issue here: you can not select all years aof a layer and have the timeslider active: in this case it has tob deactivated ( gosh all those use cases drive me crazy!)

unbenannt_error