geoadmin / mf-geoadmin3

Legacy source code of map.geo.admin.ch
https://map.geo.admin.ch
Other
227 stars 72 forks source link

import WMS/WMTS improve attribution #3864

Open davidoesch opened 7 years ago

davidoesch commented 7 years ago

Situation: currently attribution is domain

Task check if GetCap has

Fees and AccessConstraints at service level (…</Service) or at the layer level ( -> -> ) According to 7.2.4.3 General service metadata

eg http://www.opengeospatial.org/standards/wms if those kewords exist

Action -[ ] use Fees/Access constraints for footer copyright text -[ ] if and Text is longer than 50 char, cut it at 50 char -[ ] if no Fees/Access constraints is available or is "none" use domain name as we do for now

result Attribution is optimized ( and no, I don't have a working example)

Addendum

in geocat CSW, it can be solved with -MD_Identification.pointOfContact > resourceconstaints > MD_LegalConstraints >accessConstraints (Codelist) AND -MD_Identification.pointOfContact > resourceconstaints > MD_LegalConstraints >otherConstraints (characterString containing cosntraints) AN/OR o (Swiss extension ISO) MD_Identification.pointOfContact > resourceconstaints > MD_LegalConstraints > legislationConstraints > title > CI_Citation (complete classes for eg licences)

p1d1d1 commented 7 years ago

This is a little tricky. I try to summarize:

WMS

and are defined at service level and it's free text. Here is where one could say "Le service est réservé aux membres de ......." is defined at layer level. Here is where one could state "Data from (c) OSM". *WMTS* at layer level in not available. is IMHO more close to what we intend with attribution in map.geo.admin.ch. Unfortunately: 1) the tag is very rarely used 2) not available in WMTS
davidoesch commented 7 years ago

We focus on Service level-- here it is available for both WMS and WMTS

sfkeller commented 7 years ago

I support this issue to use 'Fee' at Service level.

I've investigated a bit: 7.2.4.3 General service metadata obviously does to ISO 19128 WMS spec. (not to WMTS - but Ok). Fee / AccessConstraints (e.g. with value 'none' when there s none) are also mentioned by INSPIRE Viewer Services and GDI-DE. There this seems to be a very important information in order to be compliant with their guidelines.

I currently don't know of any Swiss WMTS service - except german ones (see below). Given the GeoAdmin WMTS overlay feature is so new it's obvious that it's not yet there.

As already mentioned, showing Attribution of an overlay is compliancy requirement of most geodata sources, including gov. data, commercial data and OSM.

So, I think many WMTS providers would be happy when you raise the prio a little bit in order to make GeoAdmin an even greater service :-).

davidoesch commented 7 years ago

wms with access constraints: https://owsproxy.lgl-bw.de/owsproxy/ows/WMS_Maps4BW?request=GetCapabilities&service=WMS&Version=1.3.0

oterral commented 7 years ago

Fee/Access constraint are always more than 50 characters so it's useless to display it.

sfkeller commented 7 years ago

Fee/Access constraint are always more than 50 characters so it's useless to display it.

That statement is not true. See e.g. (c) "OpenStreetMap Contributors" at osm.org or "© Mapbox © OpenStreetMap" at mapbox.com/maps which is around 24 chars.

There may be practical restrictions of max. char length to display. But let me be clear on this issue: The display of attribution is a legal requirement (and also an ethical) of any web app including this one, and since we have a solution at hand, there is no reason to wait implementing it now.

P.S. The WMTS from osm.ch is now ready to test the fees tag.

oterral commented 7 years ago

Yes for fee. I meant AccesConstraint is often more than 50 character.

davidoesch commented 7 years ago

As summarized by https://github.com/geoadmin/mf-geoadmin3/issues/3864#issuecomment-309389156 and defiend in the ticket: we need a solution for WMS,WMTS,KML,GPX,JSON --with fallback

sfkeller commented 7 years ago

Let's concentrate on services first, which is WMS,WMTS, and advance step by step.

davidoesch commented 7 years ago

we analyze how many of the current external sources support this feature https://github.com/geoadmin/mf-geoadmin3/blob/master/src/js/ImportController.js then we decide how we proceed. and since import module is a joint dev with cantons and cities https://github.com/camptocamp/ngeo we will coordinate the approach with them as well ...

boecklic commented 5 years ago

Proposed solution: attribution line contains domain of wms as it is doing currently, if AccessConstraints available in wms/wmts getcap: show content of it (e.g. from https://owsproxy.lgl-bw.de/owsproxy/ows/WMS_Maps4BW?request=GetCapabilities&service=WMS&Version=1.3.0)

<AccessConstraints>
Der Darstellungsdienst Maps4BW kann für kommerzielle und nicht-kommerzielle Anwendungen unter den Bedingungen der Lizenz CC BY 3.0 (http://creativecommons.org/licenses/by/3.0/) kostenfrei genutzt werden. Die kostenfreie Nutzung von Maps4BW ist erlaubt, wenn an gut sichtbarer Stelle folgende Quellenangabe angeben wird: "Datengrundlage: LGL, www.lgl-bw". Maps4BW liegen nicht offene Geobasisdaten zugrunde, deren Nutzung einer gesonderten Vereinbarung bedarf.
</AccessConstraints>

it is shown in the popover/mouseover instead of the current "Dataset and/or style provided by third party"