search

geoadmin / mf-geoadmin3

Legacy source code of map.geo.admin.ch
https://map.geo.admin.ch
Other
227 stars 72 forks source link

[MVT] Borders over text #4721

Closed davidoesch closed 5 years ago

davidoesch commented 5 years ago

open https://s.geo.admin.ch/7fdf489857

on win10 chrome

image

expected: country border is behind text

deniers commented 5 years ago

same issue as #4739 ?

deniers commented 5 years ago

seems that order of layers is different than specified in the style?

pakb commented 5 years ago

that's a separate issue. It's caused by the fact that we make two layer groups in OpenLayers for each sources (OSM and Swisstopo), and those sources are managed separately for declutering and ordering.

As we can't juridically merge the two sources in the style, the only way to solve this would be to programmatically merge the two sources with a custom OL loader (as proposed on this PR https://github.com/geoadmin/mf-geoadmin3/pull/4523). I'll give it a try when bigger issues are fixed.

pakb commented 5 years ago

Now that OSM cut is good with labels (no more labels over Switzerland), we should have OSM labels over our data (but beneath our labels) in the style JSON. Is that OK with you @swissgis3084 ?

davidoesch commented 5 years ago

We will take this into the project steering group

deniers commented 5 years ago

where can I see it? currently I can see this: (https://test.map.geo.admin.ch) image Not sure if these kind of Problems can ever be solved, if OpenLayers creates seperate layer groups for OSM and swisstopo data

pakb commented 5 years ago

this happens because layers are ordered this way in our style :

If we can place OSM labels after our data, foreign labels would be on top of lakes and such features.