Gjn updateol newbuild - Githubissues

geoadmin / ol3

OpenLayers 3

http://ol3js.org/

Other

11 stars 6 forks source link

Gjn updateol newbuild #82

Closed gjn closed 10 years ago

gjn commented 10 years ago

This PR

updates to latest master of ol3 (https://github.com/openlayers/ol3/commit/ba060ccc502fb7c52edbb8eb159ca4db4d9e64ff)
adapts the build to the new build system. As we don't want custom ol3 build for our api, we simply get rid of the exports files and use the @todo api notation to export the symbols we want.

Not fully tested yet.

procrastinatio commented 10 years ago

Di you commit your last change , I have the following error:

2014-06-10 09:10:44,484 build/exports.js: node tasks/generate-exports.js build/exports.js
Trouble generating info:
/home/ltmom/geoadmin-ol3/node_modules/jsdoc/cli.js:341
     packageDocs = new Package(props.packageJson);

gjn commented 10 years ago

Updated to latest ol3 master https://github.com/geoadmin/ol3/commit/b977d85229d0ccb2a174a94fae287ce933d08b8a

We have issues with DOM renderer and aggregated layers (see ga-side-by-side example). This is minor, but I'm having a look.

Otherwise, examples are working fine.

gjn commented 10 years ago

Looks like our DOM renderer issues is already behaving like this in current geoadmin3/master...so the regression was introduced before this PR.

procrastinatio commented 10 years ago

All geoadmin examples, but ga-static-whitespace and ga-static-build, are OK. These two fail to compile with:

Caused by: java.io.FileNotFoundException: /home/ltmom/geoadmin-ol3/build/examples/../../buildcfg/../examples/ga-static-whitespace.js (No such file or directory)

and

java.io.FileNotFoundException: /home/ltmom/geoadmin-ol3/build/examples/../../buildcfg/../examples/ga-static-whitespace.js (No such file or directory)

gjn commented 10 years ago

Using the 'hosted' examples approach?

With plovr, all examples (with the exception I mentioned) are working.

procrastinatio commented 10 years ago

No, with plovr

gjn commented 10 years ago

Can you describe how to reproduce it? I just tested it 20 minutes ago and it worked fine.

procrastinatio commented 10 years ago

This is related to https://github.com/geoadmin/ol3/commit/bab587aa1b0df0b70ca58422833ff5c9558beac8, we did rename two files, but I see why we have these two examples.

gjn commented 10 years ago

So change needed? Or can we let @cedricmoullet merge?

cedricmoullet commented 10 years ago

I just tested and it works fine. I merge