search

geoadmin / ol3

OpenLayers 3
http://ol3js.org/
Other
11 stars 6 forks source link

gaTooltip can be enabled and disabled programmatically. #99

Closed DKPillo closed 10 years ago

DKPillo commented 10 years ago

Added Functions enableTooltip and disableTooltip to ga.Map. Added property enabled to ga.Tooltip. Adden Functiond enable and disable to ga.Tooltip.

gjn commented 10 years ago

@DKPillo thanks alot for the contribution.

Added a couple of comments. If you address them, I think this is a good addition. What do you think @procrastinatio and @cedricmoullet ?

DKPillo commented 10 years ago

@gjn thanks for review. I Hope this is now as you expect.

gjn commented 10 years ago

Thanks alot for the update. This looks good to me.

I'll let @cedricmoullet decide if we want to have this functionality in our API.

+1 from me.

procrastinatio commented 10 years ago

Nice, from our side we also need to change some layers settings dynamically, for instance the timestamp. So it OK to me.

gjn commented 10 years ago

Thanks for the review. I'll merge.

cedricmoullet commented 10 years ago

So it probably doesn't need my input anymore. I have not seen the détails, but the idea is good.

Le 25 juil. 2014 à 14:06, Gilbert Jeiziner notifications@github.com a écrit :

Merged #99.

— Reply to this email directly or view it on GitHub.