search

geoadmin / routing-graph-packager

Valhalla routing network packager for OSM data.
3 stars 1 forks source link

configurable tmp dir #30

Closed chrstnbwnkl closed 3 months ago

chrstnbwnkl commented 4 months ago

Proposed Changes

This PR separates the directories for created packages and all other files (i.e. planet PBF, graph, etc.). DATA_DIR refers to the location where all created packages will be stored whereas TMP_DIR stores the planet PBF, the graph tiles, elevation data, and so on.

Migration

Migration should be easy, just move all the files that are not packaged extracts to the new TMP_DATA_DIR location before starting the services.

chrstnbwnkl commented 4 months ago

we can run the test once the update only PR is merged and we change the target branch to main :)

nilsnolde commented 3 months ago

hm, I just realize CI is still running on ubuntu 20.04. might wanna change that to ubuntu-latest (either here or at some point).

nilsnolde commented 3 months ago

It might also be good to have a test in place. Current tests are checking whether a package was created and has the right graph packaged, but all from a request's response. I guess it'd be enough to check the path set by the env var?

nilsnolde commented 3 months ago

hm, I just realize CI is still running on ubuntu 20.04. might wanna change that to ubuntu-latest (either here or at some point).

was thinking about the other PR :sweat_smile:

chrstnbwnkl commented 3 months ago

It might also be good to have a test in place. Current tests are checking whether a package was created and has the right graph packaged, but all from a request's response. I guess it'd be enough to check the path set by the env var?

End to end testing is not trivial, we don't actually push the jobs in the Arq queue when testing. This would require us to have a distinct test setup with only a small PBF instead of the planet and so on... maybe something for the future.