search

geoadmin / service-alti

Height/profile services for geo.admin.ch
Other
2 stars 2 forks source link

BGDIINF_SB-1833: correction to profile validation #83

Closed ltkum closed 3 years ago

ltkum commented 3 years ago

based on @gberaudo initial PR, but I must admit I'm not going to make a PR on a fork for this.

So, the problem was with our implementation (and gberaudo was right in its change). The problem is that in our unit tests, we were serializing json twice, and then get_json() returned a string (since a string is a valid json), and so it worked in the end. I left the initial implementation as is, and corrected the double serialization in tests.

Thanks @ltshb for the help in debugging this (and stopping me from getting too far down the rabbit hole once again).

ltkum commented 3 years ago

based on https://github.com/geoadmin/service-alti/pull/81

tests work locally, I'm going to check what is wrong on AWS

pakb commented 3 years ago

my, my, a linter error, how unexpected 😉