search

geoadmin / web-mapviewer

The viewer application for maps and geodata
https://map.geo.admin.ch
Other
57 stars 9 forks source link

PB-790: Update mapfishprint to include fix for empty text on annotation. - #patch #1011

Closed ismailsunni closed 4 weeks ago

ismailsunni commented 1 month ago

UPDATE: DO NOT MERGE this PR before a new version of mapfishprint is released.

This fix should be updated after https://github.com/geoblocks/mapfishprint/pull/35 is merged and new version is released.

Test link

cypress[bot] commented 1 month ago

Passing run #3021 ↗︎

0 210 21 0 Flakiness 0

Details:

PB-790: Fix unit test and remove old hack fix.
Project: web-mapviewer Commit: a4a4d9e58c
Status: Passed Duration: 04:44 💡
Started: Jul 24, 2024 12:00 PM Ended: Jul 24, 2024 12:04 PM

Review all test suite changes for PR #1011 ↗︎

ismailsunni commented 1 month ago

@ltshb yes, that's what I mean with my comment in the PR description. But after I read it again, it doesn't say like that.

And yes, it shouldn't be merged until we have a new version released.

I tried to change it back to a draft PR, but it seems it's not possible.

ismailsunni commented 4 weeks ago

Superseded by #1021