geoadmin / web-mapviewer

The viewer application for maps and geodata
https://map.geo.admin.ch
Other
57 stars 9 forks source link

Regression of PR885 - Flight tracks are unexpectedly clampedToGround #1016

Closed t0b3 closed 1 week ago

t0b3 commented 1 month ago

PR https://github.com/geoadmin/web-mapviewer/pull/885 introduced a regression:

state before PR#885 == expected result https://sys-map.dev.bgdi.ch/preview/bug_pb-562_wrong_external_kml_style/index.html#/map?sr=3857&center=802000,5970370&camera=7.204872,47.173075,1477,-5,51,&z=17&3d&bgLayer=ch.swisstopo.swisstlm3d-karte-farbe_3d&layers=KML%7C208_Weissenstein_20_07_2024.kml image

state after PR#885 == actual result https://sys-map.dev.bgdi.ch/preview/bug_pb-591_3d_kml_improvments/index.html#/map?sr=3857&center=802000,5970370&camera=7.204872,47.173075,1477,-5,51,&z=17&3d&bgLayer=ch.swisstopo.swisstlm3d-karte-farbe_3d&layers=KML%7C208_Weissenstein_20_07_2024.kml image

unfortunately theese two overrides ignore existing KML settings like <altitudeMode>absolute</altitudeMode> and opacity https://github.com/geoadmin/web-mapviewer/blob/1428f4f27fa6489868c0d19fab2d32cbe3b1b6c0/src/modules/map/components/cesium/CesiumKMLLayer.vue#L54-L55

while clampToGround may make a lot of sense in some cases - for polylines it's not generally applicable ;-)

nb: does cesium parse altitudeMode well enough, doesn't it?

ltshb commented 1 month ago

@t0b3 thanks for notifying us, we will have a look at it.

ltshb commented 1 month ago

Internal ticket created at PB-865

pakb commented 1 week ago

Hi @t0b3 , could you give a try on this Test link with the file you linked above? As it is a local file, it wasn't shared with us. And I couldn't test it myself

t0b3 commented 1 week ago

@pakb while the path is now visible in the correct altitude :+1: image let me share those observations:

pakb commented 1 week ago

Will be deployed in the next couple days on map.geo.admin.ch (I still have to found out why no background was shown in 3D)

pakb commented 1 week ago

@t0b3 it should now be available on https://map.geo.admin.ch if you want to test it again

pakb commented 1 week ago

the issue with KML is a known bug in 3D, but we sadly don't have an easy fix for that, we will be working more on 3D for the next version

t0b3 commented 1 week ago

@pakb thanks for the fix :smile: it works like a charm on PROD now (as you mentioned except for KML opacity)