search

geoadmin / web-mapviewer

The viewer application for maps and geodata
https://map.geo.admin.ch
Other
57 stars 9 forks source link

PB-866: Fix undefined profile name for GPX track and fix crash in left click on 3D - #patch #1020

Closed ltshb closed 1 month ago

ltshb commented 1 month ago

When displaying a GPX track, its title in the profile was undefined. This was due to the fact that GPX on a ol feature seems to have no ID, but have a name.

Also fixed a crash on 3d view when clicking on the map (preventing any feature identify).

Test link

ltshb commented 1 month ago

@pakb I've noticed that identify of vectore layer (kml or gpx) on 3D is not working, I quickly (2min) debug it but could not find the issue, I don't know if there is any ticket yet for this issue, could you double check if there is any ticket and create one if needed (as I'm not working today, If just fixed this for my personal usage, preparation for my weekend 😉 ) ? thanks.

cypress[bot] commented 1 month ago


Test summary

210 • 0 • 21 • 0

Run details
Project web-mapviewer
Status Passed
Commit 4b8f4b9cf6
Started Aug 7, 2024 7:20 AM
Ended Aug 7, 2024 7:25 AM
Duration 04:18 💡
OS Linux Ubuntu -
Browser Electron 118

View run in Cypress Cloud ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

pakb commented 1 month ago

I don't know if there is any ticket yet for this issue, could you double check if there is any ticket and create one if needed

Ticket created 👍 https://jira.swisstopo.ch/browse/PB-867