search

geoadmin / web-mapviewer

The viewer application for maps and geodata
https://map.geo.admin.ch
Other
57 stars 9 forks source link

PB-154: Geolocation device orientation (gyroscope) - #minor #1022

Closed ltshb closed 1 week ago

ltshb commented 1 month ago

This PR replaced the initial work of #965

Testing slack canvas: https://swisstopo.slack.com/docs/TG623EKS6/F07GV0DQS7L

It also fixes some bugs related to goelocation see commits.

Because of some issues with some android devices (mostly samsung devices), the device orientation is only enabled on device where we can be sure that it works well, meaning Iphone and Pixel phone.

Test link

Test link

cypress[bot] commented 1 month ago

web-mapviewer    Run #3168

Run Properties:  status check passed Passed #3168  •  git commit 3b52e3214e: PB-154: Adapted the debug backend tool look
Project web-mapviewer
Branch Review feat-PB-154-geolocation-orientation
Run status status check passed Passed #3168
Run duration 05m 06s
Commit git commit 3b52e3214e: PB-154: Adapted the debug backend tool look
Committer Brice Schaffner
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 21
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 210
View all changes introduced in this branch ↗︎
schtibe commented 1 month ago

As discussed with @ltshb, Absolute Listener with Alpha Value is OK on Mozilla/5.0 (Linux; Android 10; K) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/127.0.0.0 Mobile Safari/537.36