geoadmin / web-mapviewer

The viewer application for maps and geodata
https://map.geo.admin.ch
Other
57 stars 9 forks source link

Added SSL for the local development server - #minor #1023

Closed ltshb closed 1 month ago

ltshb commented 1 month ago

This helps to test some features like the geolocation on device mobile which requires ssl (at least on iphone).

Test link

ltshb commented 1 month ago

meaning it will be an auto-signed certificate? Does it still work with the more sensitive browers? (Safari on mobile for instance)

@pakb Yes the only drawback is that you always have to use https and bypass browser protection by saying each times you know what you do. This is usefull to test geolocation on mobile (iphone) as you are not allowed to enable geolocation on http ! But I could let the code in and commented so if we need it we can simply uncomment it ?

pakb commented 1 month ago

meaning it will be an auto-signed certificate? Does it still work with the more sensitive browers? (Safari on mobile for instance)

@pakb Yes the only drawback is that you always have to use https and bypass browser protection by saying each times you know what you do. This is usefull to test geolocation on mobile (iphone) as you are not allowed to enable geolocation on http ! But I could let the code in and commented so if we need it we can simply uncomment it ?

Is the code still served as unsecured in parallel or only HTTPS? If only HTTPS, I would propose to add a new npm run dev:https or npm run dev:ssl for the use case of GeolocationAPI testing (and other APIs that requires HTTPS)

cypress[bot] commented 1 month ago



Test summary

210 0 21 0


Run details

Project web-mapviewer
Status Passed
Commit 0f0f087390
Started Aug 12, 2024 4:57 AM
Ended Aug 12, 2024 5:02 AM
Duration 05:02 💡
OS Linux Ubuntu -
Browser Electron 118

View run in Cypress Cloud ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud